From a4643529db20dfa4a631f143a4d78c675821ee3f Mon Sep 17 00:00:00 2001
From: Conatum <cona@thewisewolf.dev>
Date: Fri, 22 Sep 2023 12:05:27 +0300
Subject: [PATCH] fix(rmenus): Better handling of post errors.

---
 src/modules/rolemenus/cog.py           |  9 +++++++--
 src/modules/rolemenus/ui/menueditor.py | 18 +++++++-----------
 2 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/src/modules/rolemenus/cog.py b/src/modules/rolemenus/cog.py
index a3cb9d6a..3724cb76 100644
--- a/src/modules/rolemenus/cog.py
+++ b/src/modules/rolemenus/cog.py
@@ -976,11 +976,16 @@ class RoleMenuCog(LionCog):
         if rawmessage is not None:
             msg_config = target.config.rawmessage
             content = await msg_config.download_attachment(rawmessage)
-            data = await msg_config._parse_string(content)
+            data = await msg_config._parse_string(0, content)
             update_args[msg_config._column] = data
             if template is None:
                 update_args[self.data.RoleMenu.templateid.name] = None
-            ack_lines.append(msg_config.update_message)
+            ack_lines.append(
+                t(_p(
+                    'cmd:rolemenu_edit|parse:custom_message|success',
+                    "Custom menu message updated."
+                ))
+            )
 
         # Update the data, if applicable
         if update_args:
diff --git a/src/modules/rolemenus/ui/menueditor.py b/src/modules/rolemenus/ui/menueditor.py
index 3af0101f..dca450b7 100644
--- a/src/modules/rolemenus/ui/menueditor.py
+++ b/src/modules/rolemenus/ui/menueditor.py
@@ -644,7 +644,7 @@ class MenuEditor(MessageUI):
             self.bot, json.loads(self.menu.data.rawmessage), callback=self._editor_callback, callerid=self._callerid
         )
         self._slaves.append(editor)
-        await editor.run(interaction)
+        await editor.run(interaction, ephemeral=True)
 
     # Template/Custom Menu
     @select(cls=Select, placeholder="TEMPLATE_MENU_PLACEHOLDER", min_values=1, max_values=1)
@@ -821,20 +821,15 @@ class MenuEditor(MessageUI):
         """
         Display or update the preview message.
         """
-        args = await self.menu.make_args()
-        view = await self.menu.make_view()
         if self._preview is not None:
             try:
                 await self._preview.delete_original_response()
             except discord.HTTPException:
                 pass
             self._preview = None
-        await press.response.send_message(
-            **args.send_args,
-            view=view or discord.utils.MISSING,
-            ephemeral=True
-        )
+        await press.response.defer(thinking=True, ephemeral=True)
         self._preview = press
+        await self.update_preview()
 
     async def preview_button_refresh(self):
         t = self.bot.translator.t
@@ -887,13 +882,14 @@ class MenuEditor(MessageUI):
                         description=desc
                     )
                     await selection.edit_original_response(embed=embed)
-                except discord.HTTPException:
+                except discord.HTTPException as e:
                     error = discord.Embed(
                         colour=discord.Colour.brand_red(),
                         description=t(_p(
                             'ui:menu_editor|button:repost|widget:repost|error:post_failed',
-                            "An error ocurred while posting to {channel}. Do I have sufficient permissions?"
-                        )).format(channel=channel.mention)
+                            "An unknown error ocurred while posting to {channel}!\n"
+                            "**Error:** `{exception}`"
+                        )).format(channel=channel.mention, exception=e.text)
                     )
                     await selection.edit_original_response(embed=error)
                 else: